Skip to content

Conversation

@ericokuma
Copy link
Contributor

Fixes APP-581: Dashboard dimension search failing with trailing spaces.

Previously, searching for a dimension with a trailing space (e.g., "site ") would incorrectly return "No matching dimensions". This change trims the search input before filtering, ensuring that leading or trailing whitespace does not interfere with matching dimensions.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Linear Issue: APP-581

Open in Cursor Open in Web

@ericokuma ericokuma marked this pull request as ready for review November 18, 2025 23:14
@ericokuma ericokuma requested review from lovincyrus and removed request for ericpgreen2 November 18, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants