-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Update prism-launcher #23152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prism-launcher #23152
Conversation
|
Thank you for your contribution! 🎉 🔔 @lockieluke @tomjpeg @pernielsentikaer you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
Greptile OverviewGreptile SummaryThis PR fixes a Windows compatibility issue and adds version information display for Minecraft instances. The main changes include:
Critical Issues:
Confidence Score: 1/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
extensions/prism-launcher/src/utils/preferences.ts, line 1-5 (link)logic:
Preferencestype definition removed but still used. This will cause TypeScript compilation error. Need to add:
9 files reviewed, 4 comments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
I'm afraid this fix isn't the one we're looking for, it's unable to get the full path to the chosen executable path due to an underlying bug in Raycast on Windows. I have submitted a PR #23160 that mitigates this with a temporary fix until Raycast fixes the issue with The other changes you've made look good to me, I would probably wait for my PR to merge(probably needs a new PR after that) before merging in the changes you've made to how the extension displays versions. Great work, thanks for contributing to this extension! |
|
oh ok ill remove the fix portion and keep the other changes |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool