Skip to content

Conversation

@TakenMC
Copy link
Contributor

@TakenMC TakenMC commented Nov 25, 2025

Description

  • Fixed a bug on windows where it wouldn't be able to get Prism Launcher
  • Added current versions for intances in launch instance and join server commands

Screencast

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: prism-launcher Issues related to the prism-launcher extension platform: macOS platform: Windows OP is contributor The OP of the PR is a contributor of the extension labels Nov 25, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Nov 25, 2025

Thank you for your contribution! 🎉

🔔 @lockieluke @tomjpeg @pernielsentikaer you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 25, 2025

Greptile Overview

Greptile Summary

This PR fixes a Windows compatibility issue and adds version information display for Minecraft instances. The main changes include:

  • Fixed Windows path handling by changing from appPicker to file type and updating path format from %LOCALAPPDATA% to ~ syntax
  • Added version display showing Minecraft, Forge, and Fabric versions in instance lists
  • Improved error handling for Windows when Prism Launcher path is not found
  • Added loading states to prevent empty state flicker

Critical Issues:

  • The Preferences type definition was removed from preferences.ts but is still used throughout the codebase, causing a TypeScript compilation error
  • Multiple spelling errors: "intances" in CHANGELOG and "instace" parameter name in prism.ts

Confidence Score: 1/5

  • This PR has critical compilation errors that will prevent it from building
  • The removal of the Preferences type definition will cause TypeScript compilation to fail, making the extension non-functional. Additionally, there are spelling errors that need correction.
  • extensions/prism-launcher/src/utils/preferences.ts must be fixed immediately - the missing type definition will break the build. extensions/prism-launcher/src/utils/prism.ts needs spelling correction in parameter name.

Important Files Changed

File Analysis

Filename Score Overview
extensions/prism-launcher/CHANGELOG.md 3/5 Added new changelog entry with correct format but contains typo "intances"
extensions/prism-launcher/package.json 4/5 Changed installPath from appPicker to file type and updated Windows path format from %LOCALAPPDATA% to ~ syntax
extensions/prism-launcher/src/utils/preferences.ts 0/5 Removed Preferences type definition causing compilation error - type is still referenced but no longer defined
extensions/prism-launcher/src/utils/prism.ts 2/5 Added version display feature for instances, fixed Windows path handling, but contains typo in parameter name "instace"

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. extensions/prism-launcher/src/utils/preferences.ts, line 1-5 (link)

    logic: Preferences type definition removed but still used. This will cause TypeScript compilation error. Need to add:

9 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

TakenMC and others added 2 commits November 25, 2025 16:01
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@lockieluke
Copy link
Contributor

lockieluke commented Nov 25, 2025

I'm afraid this fix isn't the one we're looking for, it's unable to get the full path to the chosen executable path due to an underlying bug in Raycast on Windows. I have submitted a PR #23160 that mitigates this with a temporary fix until Raycast fixes the issue with appPicker preferences. Changing installPath to type file would break the extension on macOS as app bundles on macOS are either directory or appPicker.

The other changes you've made look good to me, I would probably wait for my PR to merge(probably needs a new PR after that) before merging in the changes you've made to how the extension displays versions. Great work, thanks for contributing to this extension!

@TakenMC
Copy link
Contributor Author

TakenMC commented Nov 25, 2025

oh ok ill remove the fix portion and keep the other changes

@TakenMC TakenMC closed this Nov 26, 2025
@TakenMC TakenMC deleted the ext/prism-launcher branch November 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: prism-launcher Issues related to the prism-launcher extension OP is contributor The OP of the PR is a contributor of the extension platform: macOS platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants