[docker-py] Fix the type of `Model` and `Collection` `client` attribute #15083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

roberfi wants to merge 1 commit into python:main from roberfi:fix-client-type

Contributor

roberfi commented Nov 25, 2025

I see that the type of Model and Collection client attribute is wrong. APIClient is used but it should be DockerClient.

Evidence:

All Collection objects are initialized with self as client argument in DockerClient class: https://github.com/docker/docker-py/blob/df3f8e2abc5a03de482e37214dddef9e0cee1bb1/docker/client.py#L102C1-L181C45
Model is then initialized within Collection class using as self.client as the client argument: https://github.com/docker/docker-py/blob/df3f8e2abc5a03de482e37214dddef9e0cee1bb1/docker/models/resource.py#L90C13-L90C80


          [docker-py] Fix the type of Model and Collection client attribute

04002b9

Contributor

github-actions bot commented Nov 25, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet