Introduce immutable hook option classes for type safety #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook implementation and specification options are now represented by immutable classes (HookimplOptions, HookspecOptions) internally. This provides stronger type guarantees and prevents accidental mutation of option data after hook registration. For backward compatibility with pytest's custom parsing methods, the public parse_hookimpl_opts and parse_hookspec_opts methods continue to return TypedDict representations, while new internal helpers handle conversion to the immutable classes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hook implementation and specification options are now represented by
immutable classes (HookimplOptions, HookspecOptions) internally. This
provides stronger type guarantees and prevents accidental mutation of
option data after hook registration.
For backward compatibility with pytest's custom parsing methods, the
public parse_hookimpl_opts and parse_hookspec_opts methods continue to
return TypedDict representations, while new internal helpers handle
conversion to the immutable classes.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]