asn1.py: treat asn1_string_st as opaque #13910
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
oh my god, apparently pyopenssl still uses internals 😭. Looks like we have |
Contributor
Author
|
I see this causes issues in pyopenssl which will need to be addressed first. |
alex
reviewed
Nov 22, 2025
Member
|
pyca/pyopenssl#1462 has the fix -- will mark this for the next milestone and expect to rebase/merge after our next pyopenssl release. |
OpenSSL 4 plans to make ASN1_STRING opaque [1]. Using a forward declaration rather than a redefinition avoids the build breakage in cryptography's cffi when it tries to validate the sizes of the members. [1]: openssl/openssl#29117
botovq
force-pushed
the
opaque-asn1-string
branch
from
1418191 to
e2a8124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 4 plans to make ASN1_STRING opaque. Using a forward declaration rather than a redefinition avoids the build breakage in cryptography's cffi when it tries to validate the sizes of the members.