Vscode ext #850
Draft
Vscode ext #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Goff <[email protected]>
This queries the frontend for available targets for the spec.t rebase --continue Signed-off-by: Brian Goff <[email protected]>
Before this change the builder just always included "." as the main build context. It could not include other contexts either (such as when a source specifies a named context). With this change it asks the user to provide the path to whatever contexts are needed. Signed-off-by: Brian Goff <[email protected]>
This allows just re-running exactly the last build with the same exact inputs (and does not prompt the user for inputs). Signed-off-by: Brian Goff <[email protected]>
Requires an env var to enable it. This is because it doesn't actually seem to work right now as there are some missing pieces that need to be investigated. Signed-off-by: Brian Goff <[email protected]>
This groups targets by section (e.g. `azlinux3`, `bookworm`, etc). It also includes the description of the target. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
First prompt is the top-level entry (e.g. azlinux3, bookworm, bullseye, debug, etc). The 2nd prompt is the target list filtered to the selection from the first prompt. Signed-off-by: Brian Goff <[email protected]>
Before the codelens just said "spec.json" which is confusing. Now it says dalec-jsonschema.json. Really I don't think the codelens is useful, but its a configuring in the yaml plugin, not our extension. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
When we evaluate the state this breaks the debugger. There is still one place where we unlazy the build, and that is in the test runner when we need to read a file off the file system for the test results. This is a larger change and will be hanlded in a separate commit. Signed-off-by: Brian Goff <[email protected]>
This is useful while testing buildx builds, we can point the extension at a custom binary. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
vscode_ext
branch
3 times, most recently
from
ff45633 to
eafeedb
Compare
Some things in here are a bit hacky. Tests can modify the filesystem (even cause packages to be installed), but we don't want those changes to be in the result we give to buildkit. But if we don't include the test state in the build result then the tests won't be executed... so this tries to get around the issue by derving new a new state from the test state that *should* have the same filesystem as the original, pre-test state. This makes it so the dap debugger works when the spec has tests. Signed-off-by: Brian Goff <[email protected]>
1 task
This generates the vsc extension and loads VSC with the extension in dev mode. Signed-off-by: Brian Goff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: