Adds file property to WebAudioMedia for access to downloaded audio file data.
#276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to make the raw audio data available from
WebAudioMediaso things like meta ID3 tags can be accessed without requiring additional network calls. Here is my take, although I'm not sure if this is the best route for other use-cases. If not, it would still be great to have some way to access the responseArrayBufferapart from this class's immediate conversion to anAudioBuffer.If there's a standard way to extend `WebAudioMedia" and have Sound use the extended class instead, that could work as well: I just wasn't sure about how to approach that.