Skip to content

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 30, 2025

What problem does this PR solve?

Issue Number: close #63810

Problem Summary:

What changed and how does it work?

Previously, we didn't pay attention to reusing the slices of columns, which led to a lot of memory allocation here. We have specially optimized this.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 30, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.4050%. Comparing base (8ddebe9) to head (2510bef).
⚠️ Report is 241 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63829        +/-   ##
================================================
+ Coverage   72.7352%   73.4050%   +0.6697%     
================================================
  Files          1849       1850         +1     
  Lines        499587     499936       +349     
================================================
+ Hits         363376     366978      +3602     
+ Misses       114126     111004      -3122     
+ Partials      22085      21954       -131     
Flag Coverage Δ
integration 41.8434% <66.6666%> (?)
unit 72.5404% <85.7142%> (+0.2642%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.4513% <ø> (+0.0379%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hawkingrei hawkingrei force-pushed the 63810 branch 2 times, most recently from e21eeab to 870bfd9 Compare October 8, 2025 06:53
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2025
@hawkingrei hawkingrei requested a review from AilinKid October 9, 2025 03:58
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 9, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2025
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/retest

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/retest

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: King-Dylan, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 9, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-09 06:09:10.306680151 +0000 UTC m=+334139.337779479: ☑️ agreed by King-Dylan.
  • 2025-10-09 12:20:44.641799467 +0000 UTC m=+356433.672898795: ☑️ agreed by windtalker.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 3a54eaa into pingcap:master Oct 9, 2025
29 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-6.5-20241112-v6.5.11

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 17, 2025
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5-20241112-v6.5.11: #64006.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-6.5-20241112-v6.5.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #64782.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expression.ExtractColumns spends too much time in the LogicalProjection.DeriveStats

4 participants