[Mobile] - Add view document features #651

jibraniqbal666 · 2025-11-21T21:06:37Z

Keep the app logged in
Click on document
Share the document
View the document (Will do in next PR) [Mobile] - In-App Document Viewer jibraniqbal666/papra#1

screen-20251125-021818-1764019066497.mp4

changeset-bot · 2025-11-21T21:06:41Z

⚠️ No Changeset found

Latest commit: 66af4d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot

Pull request overview

This PR adds document viewing features to the mobile app, focusing on authentication persistence, document interaction, and file sharing capabilities.

Key Changes

Added authentication session persistence to keep users logged in
Implemented document action sheet for user interaction (tap on document to view actions)
Added document download and share functionality using expo-sharing

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
`pnpm-lock.yaml`	Updated dependencies including `expo-sharing` and `@react-native-community/cli`
`apps/mobile/package.json`	Added `expo-sharing` dependency and React Native CLI dev dependency
`apps/mobile/tsconfig.json`	Added JSX configuration for React Native
`apps/mobile/app/index.tsx`	Changed default redirect to documents list (potential authentication issue)
`apps/mobile/src/modules/api/api.models.ts`	Exported `CoerceDate` type for use in other modules
`apps/mobile/src/modules/organizations/organizations.provider.tsx`	Added authentication check to keep users logged in
`apps/mobile/src/modules/documents/screens/documents-list.screen.tsx`	Added tap interaction to show document action sheet
`apps/mobile/src/modules/documents/documents.services.ts`	Implemented file download function with authentication
`apps/mobile/src/modules/documents-actions/components/document-action-sheet.tsx`	New modal component for document actions (view/share)

Comments suppressed due to low confidence (1)

apps/mobile/src/modules/documents-actions/components/document-action-sheet.tsx:38

Unused variable apiClient.

  const apiClient = useApiClient();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/mobile/src/modules/documents-actions/components/document-action-sheet.tsx

apps/mobile/src/modules/documents/documents.services.ts

apps/mobile/app/index.tsx

apps/mobile/src/modules/documents-actions/components/document-action-sheet.tsx

Copilot · 2025-11-24T18:19:14Z

apps/mobile/src/modules/organizations/organizations.provider.tsx


  // Load current organization ID from storage on mount
  useEffect(() => {
+


[nitpick] Remove the blank line for better code consistency.

Suggested change

apps/mobile/src/modules/documents/documents.services.ts

apps/mobile/src/modules/documents/screens/documents-list.screen.tsx

CorentinTh

Looks great, thanks! 🙏
Made some comments, let me know

Regarding the ui, love the drawer, maybe it'll be more scaleable to have a vertical list of action instead of a horizontal button stacks
A pnpm lint:fix may also be needed

CorentinTh · 2025-11-25T20:30:36Z

apps/mobile/package.json

  },
  "devDependencies": {
    "@antfu/eslint-config": "catalog:",
+    "@react-native-community/cli": "latest",


[question]
What is it used for?

I was trying to fix development build, i had some error, let me check.

CorentinTh · 2025-11-25T20:32:11Z

apps/mobile/src/modules/organizations/organizations.provider.tsx

+    if(!authClient.getCookie()) {
+      router.replace('/auth/login');
+      return;
+    }


Not sure that's the responsibility of the organization provider to manage authentication redirection 🤔

CorentinTh · 2025-11-25T20:47:47Z

apps/mobile/src/modules/documents-actions/components/document-action-sheet.tsx

+    try {
+      const fileUri = await fetchDocumentFile({
+        document: document,
+        organizationId: document.organizationId,
+        baseUrl,
+        authClient,
+      });
+
+      const canShare = await Sharing.isAvailableAsync();
+      if (canShare) {
+        await Sharing.shareAsync(fileUri);
+      } else {
+        showAlert({
+          title: 'Sharing Failed',
+          message: 'Sharing is not available on this device. Please share the document manually.',
+        });
+      }
+
+    } catch (error) {


Check for the availability of the sharing api before fetching the file to avoid unnecessary transfer

apps/mobile/src/modules/documents/screens/documents-list.screen.tsx

CorentinTh · 2025-11-25T20:52:13Z

apps/mobile/src/modules/documents/documents.services.ts

+    'Content-Type': 'application/json',
+  };
+  // Use documentDirectory for better app compatibility
+  const fileUri = `${FileSystem.documentDirectory}${document.name}`;


[question]
It looks like there will be collisions as the file isn't cleaned-up?

no it basically overrides it everytime. but let's change file system to cacheDirectory

apps/mobile/src/modules/documents-actions/components/document-action-sheet.tsx

CorentinTh · 2025-11-25T20:59:40Z

apps/mobile/app/index.tsx

    }

-    return <Redirect href="/auth/login" />;
+    return <Redirect href="/(app)/(with-organizations)/(tabs)/list" />;


I'm not really sure about the change of the redirection here, I'd prefer to have all authentication/state redirection at the same place

If you run the master app, you will see that on app killed and reload even the app is logged in, it's still goes to login page, even though it should go to document.

so i implemented to check

we go directly to home

user not logged in

go to login

other wise be at home page.

rewrote logic again.

Co-authored-by: Corentin Thomasset <[email protected]>

Co-authored-by: Copilot <[email protected]>

jibraniqbal666 · 2025-11-26T14:07:50Z

Looks great, thanks! 🙏

Made some comments, let me know

Regarding the ui, love the drawer, maybe it'll be more scaleable to have a vertical list of action instead of a horizontal button stacks

A pnpm lint:fix may also be needed

We will make it list when it exhausted. :), my idea is no future proofing, should be easy to fix later as well.

CorentinTh

Thanks for the update 🙏

Have you re-run ppnm install after removing the community cli package ? Lot of noise in the pnpm lock

Note: do not hesitate to use the re-request review cog to ping for change, it queues in my notifications

CorentinTh · 2025-11-28T21:16:35Z

apps/mobile/src/modules/documents/documents.services.ts

+  // Use documentDirectory for better app compatibility
+  const fileUri = `${FileSystem.cacheDirectory}${document.name}`;


Nice, seems better with cache directory

[Nit] Comment

Suggested change

// Use documentDirectory for better app compatibility

const fileUri = `${FileSystem.cacheDirectory}${document.name}`;

// Use cacheDirectory for better app compatibility

const fileUri = `${FileSystem.cacheDirectory}${document.name}`;

Keep the phone logged in

7d48bf1

jibraniqbal666 added 8 commits November 21, 2025 22:10

Added document sheet

034e4f0

Make button outline

3769a58

Fix colors

961e7f4

Design accroding to base design

3217f79

Design accroding to base design

6b56e46

Added download and share

c21b476

fix the login issue again

d843051

fix the login issue again

cfd3a9a

jibraniqbal666 marked this pull request as ready for review November 24, 2025 18:15

jibraniqbal666 requested a review from a team as a code owner November 24, 2025 18:15

Copilot AI review requested due to automatic review settings November 24, 2025 18:15

Copilot started reviewing on behalf of jibraniqbal666 November 24, 2025 18:16 View session

Copilot finished reviewing on behalf of jibraniqbal666 November 24, 2025 18:17

Copilot AI reviewed Nov 24, 2025

View reviewed changes

Fixed copilot suggestions

e2cf2a2

CorentinTh reviewed Nov 25, 2025

View reviewed changes

jibraniqbal666 and others added 2 commits November 26, 2025 15:04

Update document-action-sheet.tsx

6fe33ac

Co-authored-by: Corentin Thomasset <[email protected]>

Update documents-list.screen.tsx

ced7d75

Co-authored-by: Copilot <[email protected]>

jibraniqbal666 added 3 commits November 26, 2025 19:10

change to cacheDirectory

9b2027b

rewrite auth logic

4e77ff6

Ran pnpm lint:fix

66af4d2

CorentinTh reviewed Nov 28, 2025

View reviewed changes


		// Load current organization ID from storage on mount
		useEffect(() => {

		// Use documentDirectory for better app compatibility
		const fileUri = `${FileSystem.cacheDirectory}${document.name}`;

Uh oh!

[Mobile] - Add view document features #651

Are you sure you want to change the base?

[Mobile] - Add view document features #651

Conversation

jibraniqbal666 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CorentinTh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jibraniqbal666 Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jibraniqbal666 commented Nov 26, 2025

Uh oh!

CorentinTh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jibraniqbal666 commented Nov 21, 2025 •

edited

Loading

changeset-bot bot commented Nov 21, 2025 •

edited

Loading

CorentinTh left a comment •

edited

Loading

jibraniqbal666 Nov 26, 2025 •

edited

Loading