Fusesoc type #740
Open
Fusesoc type #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Putting aside the fact that we have not yet defined how the various test types are to behave (parse, build, roundtrip, base, advanced and so on), the test file seems to comprise 4 groups of parse, roundtrip and build test cases that are identical but for variations in namespace, name and version values. Why? A few tests meant to fail (there are none here) would be more useful and informative. |
Author
|
Oh, I was just copying the format of the tests in some other type already present, taking that for an appropriate level of effort. I'll see about adding some more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a type for FuseSoC cores (see https://github.com/olofk/fusesoc).