Skip to content

Conversation

@Exeloo
Copy link

@Exeloo Exeloo commented Nov 23, 2025

What does this PR do?

This PR remove file exclusion in html execution for files with node_modules in the path but only for plain paths.

Likely command that don't work actually but will work :

  • bun run ./node_modules/module/index.html
  • bun run ./index.html with CWD=/folder/node_modules/module

Examples :

Example Before After
/folder/node_modules/module/index.html Exclude Include
/folder/* Exclude node_modules scan Exclude node_modules scan
/folder/**/index.html Exclude node_modules scan Exclude node_modules scan

close #24953

How did you verify your code works?

Compiled bun and test :

  • bun run ./node_modules/module/index.html (Work)
  • bun run ./index.html with CWD=/folder/node_modules/module (Work)
  • bun run **/index.html (don't include node_modules)
  • bun run *.html with CWD=/folder/node_modules/module (don't include node_modules)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 23, 2025

Walkthrough

Removed runtime filtering that skipped resolved HTML entry paths containing "node_modules", in both glob-handling and non-glob branches, so such paths are now allowed through entry resolution.

Changes

Cohort / File(s) Summary
HTML file resolution filtering
src/js/internal/html.ts
Removed checks that filtered out resolved entry paths containing node_modules in both glob and non-glob resolution branches.

Pre-merge checks

✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing node_modules exclusion specifically for plain (non-glob) paths in HTML execution.
Description check ✅ Passed The description covers both required sections with clear explanations, examples showing before/after behavior, and comprehensive verification steps.
Linked Issues check ✅ Passed The PR directly addresses issue #24953 by removing the node_modules file exclusion for plain paths in HTML execution, matching the reported problem and requested solution.
Out of Scope Changes check ✅ Passed All changes are scoped to removing the node_modules exclusion for plain paths only; glob paths retain the exclusion. No extraneous modifications are present.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8e7e0e0 and ebde377.

📒 Files selected for processing (1)
  • src/js/internal/html.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • src/js/internal/html.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Exeloo Exeloo changed the title fix: remove node_modules file exclusion in html execution for plain path fRemove node_modules file exclusion in html execution for plain path Nov 23, 2025
@Exeloo Exeloo changed the title fRemove node_modules file exclusion in html execution for plain path Remove node_modules file exclusion in html execution for plain path Nov 23, 2025
@Exeloo Exeloo force-pushed the remove-node_modules-file-exclusion-in-html-execution branch from 8e7e0e0 to ebde377 Compare November 23, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bun run ignore HTML files when they have a node_modules folder in path

1 participant