Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

Changes

This cleans up the vscode settings to use the markdownlint config file and recomended that users install the extension.

Also remove un-used settings.

For non-trivial changes, follow the change proposal process.

@thompson-tomo thompson-tomo requested review from a team as code owners November 22, 2025 09:55
@@ -0,0 +1,5 @@
{
"recommendations": [
"davidanson.vscode-markdownlint"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but looks like this extension is based on markdownlint-cli2, and so flags a lot of things that our existing configuration (based on older version) doesn't

I'd suggest updating the repo to markdownlint-cli2 first and updating configuration to match current repo practices and then come back to this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at this and it appears that the first issue is that markdownlint-cli has not been updated.

It is however now pending in the Dashboard #4507

The marketplace listing mentions it supports both. I have also confirmed that is the case. I will submit seperate PR to update rules which will enable update to be merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr which applies the latest linting rules is ready as #4756 in that pr when I disabled a rule the violations updated in vs code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants