-
Notifications
You must be signed in to change notification settings - Fork 936
Stabilize Enabled API for synchronous instruments #4746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jack-berg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight preference towards also updating corresponding sdk spec to mixed stability, with the view part stable and the meterconfig part still in development.
Will do as a separate PR (baby steps 😉). |
Fixes #4215
Current implementation status:
xpackage: “Instrument Enabled synchronous instruments provide an Enabled method.” See the Go package docs. (1)System.Diagnostics.Metrics.Instrument.Enabled: “Gets a value that indicates if there are any listeners for this instrument.” This is the .NET runtime Metrics API that OpenTelemetry .NET uses. (2)Note that @open-telemetry/collector-maintainers would benefit from making it stable and would not have to do things like https://github.com/open-telemetry/opentelemetry-collector/blob/2e9c82787618ea7da3fada176abb45b5a30714bf/service/internal/obsconsumer/enabled.go.