Support grpc endpoint for jaeger_query_extension #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
force-pushed
the
support_jaeger_query_grpc
branch
from
90ae6f5 to
3a60899
Compare
|
@shuheiktgw what's the state of this? Looks like a unit test is failing. Also maybe someone (@swiatekm ?) could review? |
pavolloffay
reviewed
Nov 18, 2025
| note: "Support gRPC endpoint for jaeger_query extension and expose it when configured." | ||
| issues: [4358] | ||
| subtext: | | ||
| - HTTP remains defaulted to 16686; gRPC has no default and is exposed only when `jaeger_query.grpc.endpoint` is set. |
Member
There was a problem hiding this comment.
I think the default port for the jaeger query GRPC is 16685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I've added support for the gRPC endpoint in jaeger_query_extension. I made it as backward-compatible as possible and decided not to expose the gRPC endpoint by default. However, if exposing it by default is acceptable, I’m happy to make those changes. Thanks for the review!
Link to tracking Issue(s):
Testing:
Documentation: