Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Dec 2, 2025

I think publishing snapshots only daily is fine. The new daily workflow will trigger issue creation when snapshot publishing fails.

Port of open-telemetry/opentelemetry-java-contrib#2481

FWIW, java contrib repo publishing is working again, though not really convinced it's related to this change 🤷‍♂️

@trask trask requested a review from a team as a code owner December 2, 2025 03:13
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (5772c1d) to head (705ffb4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7886   +/-   ##
=========================================
  Coverage     90.08%   90.08%           
  Complexity     7325     7325           
=========================================
  Files           825      825           
  Lines         22051    22051           
  Branches       2179     2179           
=========================================
  Hits          19865    19865           
  Misses         1506     1506           
  Partials        680      680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask trask force-pushed the snapshot-failure-notification branch from 499af8e to 705ffb4 Compare December 2, 2025 03:17
@jkwatson
Copy link
Contributor

jkwatson commented Dec 2, 2025

How do we get notified of failures with these nightly jobs (just curious..not familiar with how that works)

- link-check
- publish-snapshots
if: always()
uses: ./.github/workflows/reusable-workflow-notification.yml
Copy link
Member Author

@trask trask Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we get notified of failures with these nightly jobs (just curious..not familiar with how that works)

@jkwatson this workflow_call will open an issue in the repo if the daily build fails (and it will close the issue if it later passes)

@jkwatson
Copy link
Contributor

jkwatson commented Dec 2, 2025

Will this publish a snapshot even if there are no changes in a given day? I don't think that's necessarily bad, but I just thought I'd ask to be sure.

@trask
Copy link
Member Author

trask commented Dec 2, 2025

Will this publish a snapshot even if there are no changes in a given day? I don't think that's necessarily bad, but I just thought I'd ask to be sure.

yes it will

@jkwatson jkwatson merged commit 76c622c into open-telemetry:main Dec 2, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants