chore: Added more project links to the pom.xml #2386
Conversation
|
makes sense to me 👍
this repos's tags don't have |
According to https://maven.apache.org/pom.html#SCM the `scm.url` should be a publicly browsable repository. Replaced git URI with URL to project page on Github. Added `issueManagement` and `ciManagement` information to the scm section.
dol
force-pushed
the
chore/update-scm-url
branch
from
c296ad2 to
36435d4
Compare
Good point. The new approach will reference the 
|
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
@open-telemetry/java-approvers @open-telemetry/java-instrumentation-approvers if this looks good, I'll port to the other Java repos after merging
| tag.set(tagVersion) | ||
| url.set("https://github.com/open-telemetry/opentelemetry-java-contrib/tree/${tagVersion}") |
There was a problem hiding this comment.
these probably aren't correct for snapshot builds, does that matter?
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Thanks. Having a working link on central would be nice indeed.
To @laurit 's question about snapshot builds -- I think it's fine if it's not accurate for snapshots in the short term. The snapshots aren't even browsable, and the chances of someone using a url from a downloaded pom.xml I think are minimal. If browsing ever comes back for snapshots, we can circle back then.
| @@ -1,5 +1,6 @@ | |||
| val stableVersion = "1.52.0-SNAPSHOT" | |||
| val alphaVersion = "1.52.0-alpha-SNAPSHOT" | |||
| val tagVersion by extra { "v$stableVersion" } | |||
There was a problem hiding this comment.
Why not make this a local variable if its only used in otel.publish-conventions.gradle.kts?
There was a problem hiding this comment.
I did not want to change the behavior of the release process to update the version number.
Since the tagVersion is a reference to the stableVersion no other change is require. But if the other reviewers agree, that the tag reference should only be in the otel.publish-conventions.gradle.kts I'm open to also update the update-version.sh file.
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
5 participants
Description:
According to https://maven.apache.org/pom.html#SCM the
scm.urlshould be a publicly browsable repository.Replaced git URI with URL to project page on Github.
Added
issueManagementandciManagementinformation to the scm section.Took inspiration from https://central.sonatype.com/artifact/org.apache.maven/maven/4.0.0-rc-4 and their pom.xml.
The link on https://central.sonatype.com/artifact/io.opentelemetry.contrib/opentelemetry-cel-sampler/1.51.0-alpha ends up in a 404.
Before the change
After the change
The new pom.xml would look like this. Generated with
./gradlew clean publishToMavenLocal.The
scm.urlpoints to the release version of the source code.