Skip to content

Conversation

@rafaelroquetto
Copy link
Contributor

@rafaelroquetto rafaelroquetto commented Nov 26, 2025

This PR addresses a few issues with the IP options mechanism namely:

  1. deal with IP headers already containing IP options, ensuring they are not corrupt
  2. fix a broken assumption that tc ingress == request ingress path (and likewise, tc egress == request egress path). This is not always true. In k8s for instance, we end up attaching to the host veth of a given service pod, which will see traffic leaving the POD as ingress (pod eth0 (egress) ----> (ingress) host veth).

Also add a unit test.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.26%. Comparing base (5438915) to head (6ca1022).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   55.26%   55.26%           
=======================================
  Files         253      253           
  Lines       21769    21769           
=======================================
  Hits        12031    12031           
  Misses       8911     8911           
  Partials      827      827           
Flag Coverage Δ
integration-test 23.23% <ø> (-0.02%) ⬇️
integration-test-arm ?
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <ø> (ø)
k8s-integration-test 2.73% <ø> (ø)
oats-test 0.00% <ø> (ø)
unittests 46.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant