Skip to content

fix(tests): resolve Oracle container initialization race condition #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(tests): resolve Oracle container initialization race condition #4630

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5189e87
fix(tests): resolve Oracle container initialization race condition
xiang17 Nov 20, 2025
9fa537d
check if the user is created successfully
xiang17 Nov 20, 2025
414d12d
Trim trailing whitespaces
xiang17 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions test/IntegrationTests/OracleCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ private async Task<IContainer> LaunchOracleContainerAsync(int port)
var containersBuilder = new ContainerBuilder()
.WithImage(OracleImage)
.WithEnvironment("ORACLE_RANDOM_PASSWORD", "yes")
.WithEnvironment("APP_USER", "appuser")
.WithEnvironment("APP_USER_PASSWORD", Password)
.WithName($"oracle-{port}")
.WithPortBinding(port, OraclePort)
.WithWaitStrategy(Wait.ForUnixContainer().UntilInternalTcpPortIsAvailable(OraclePort))
Expand All @@ -76,6 +74,29 @@ private async Task<IContainer> LaunchOracleContainerAsync(int port)
var container = containersBuilder.Build();
await container.StartAsync();

// Create the application user after container is ready
// First ensure the pluggable database is open, then create the user
var createUserScript = $"ALTER PLUGGABLE DATABASE ALL OPEN; " +
$"ALTER SESSION SET CONTAINER=FREEPDB1; " +
$"CREATE USER appuser IDENTIFIED BY \"{Password}\" QUOTA UNLIMITED ON USERS; " +
$"GRANT CONNECT, RESOURCE TO appuser;";

var createResult = await container.ExecAsync(new[] { "bash", "-c", $"echo \"{createUserScript}\" | sqlplus -s / as sysdba" });

if (createResult.ExitCode != 0)
{
throw new InvalidOperationException($"Failed to create Oracle user. Exit code: {createResult.ExitCode}, Output: {createResult.Stdout}, Error: {createResult.Stderr}");
}

// Verify the user was created successfully by attempting to query it
var verifyScript = "ALTER SESSION SET CONTAINER=FREEPDB1; SELECT username FROM dba_users WHERE username='APPUSER';";
var verifyResult = await container.ExecAsync(new[] { "bash", "-c", $"echo \"{verifyScript}\" | sqlplus -s / as sysdba" });

if (verifyResult.ExitCode != 0 || !verifyResult.Stdout.Contains("APPUSER"))
{
throw new InvalidOperationException($"User creation verification failed. Exit code: {verifyResult.ExitCode}, Output: {verifyResult.Stdout}");
}

return container;
}

Expand Down
Loading