-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Input/Output ports for Data Product #24554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
TypeScript types have been updated based on the JSON schema changes in the PR |
CI failed for 478fac5: Both Trivy build-and-scan jobs failed due to disk space exhaustion on CI runners - this is an infrastructure issue unrelated to the PR changes.IssueBoth Root CauseDisk space exhaustion on the GitHub Actions runner: Details
Relationship to PR ChangesThis failure is NOT related to the PR changes. This PR modifies:
None of these changes affect Docker image building, Trivy scanning behavior, or CI runner disk usage. Suggested FixThe solution is to retry the CI jobs, as this is a transient infrastructure issue. The CI runner may have been in a degraded state or had accumulated temporary files from previous builds. A fresh runner should have sufficient disk space. Reply with |
|
🔍 CI failure analysis for 998c891: Playwright retry completed for both shards with improved results: 3 failed tests reduced to 2, with 96.2% overall pass rate. Python type checking remains the only PR-related issue.IssuePlaywright retry completed for shard 6/6:
Root CausePlaywright Retry Results - BOTH SHARDS IMPROVEDShard 3/6 Comparison:
Shard 6/6 Comparison:
Combined Impact:
Analysis:
DetailsRetry Results - Shard 6/6Combined Retry SummaryPersistent failures across retry (3 total):
Flaky tests across retry (7 total):
Pass rate: 96.2% (760/790 non-flaky tests) Combined CI StatusPython Type Checking (3 failures - Related - MUST FIX):
Playwright E2E (Improved):
Maven PostgreSQL CI (1 failure - Unrelated):
Infrastructure (4 failures - Unrelated):
Suggested FixFor Python Type Checking (must fix before merge): from typing import Any, Dict, List, cast
# Line 149:
payload = {
"assets": [
cast(Dict[str, Any], port.model_dump(mode="json", exclude_none=True))
for port in ports
]
}
# Line 178:
payload = {
"assets": [
cast(Dict[str, Any], asset.model_dump(mode="json", exclude_none=True))
for asset in assets
]
}For Playwright Tests: The retry across both shards demonstrated clear improvement, validating that failures are environmental. The 3 persistent failures (ServiceForm, AutoPilot Mysql/Airflow) should not block this PR as they're completely unrelated to Data Product ports functionality.
|



Describe your changes:
This PR implements input and output port functionality for Data Products to support Data Mesh architecture patterns. Data products can now explicitly declare which data assets they consume (input ports) and which data assets they produce or expose (output ports).
Summary by Gitar
Data Model & Schema Changes:
inputPortsandoutputPortsfields to DataProduct entity as EntityReference listsINPUT_PORTandOUTPUT_PORTin entityRelationship.jsonBackend Implementation:
PUT /dataProducts/{name}/inputPorts/{add|remove}andPUT /dataProducts/{name}/outputPorts/{add|remove}SDK & Client Support:
Testing Coverage:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>or decision-making process is reflected in the issue.