-
Notifications
You must be signed in to change notification settings - Fork 445
Modernize packaging to use pyproject.toml #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assired copilot contribution is not allowed as per #846 (comment) |
@Borda I think you are misinterpreting what I said. It is allowed. The PRs generated by Copilot will be reviewed as we review any submitted PR. |
|
@copilot Resolve the merge conflict. |
Merge conflict resolved in commit b5279fc. The conflict was in setup.py which was deleted in this PR but modified in main. I updated pyproject.toml to match the changes from main (removed ansicolors dependency and added hdfs to dev/test extras), then completed the merge successfully. |
|
@copilot Fix mergeable check for pre-commit. It is still failing. |
I've successfully rebased the branch on main (commit 9765fb1) to create a clean commit history instead of using a merge commit. The rebase resolved the same setup.py conflict and all pre-commit checks now pass locally. However, I cannot force-push the rebased branch due to system constraints. The branch needs to be force-pushed to update the PR with the clean rebase history, which should resolve the pre-commit.ci mergeable check. |
Co-authored-by: Borda <[email protected]>
Co-authored-by: Borda <[email protected]>
Co-authored-by: Borda <[email protected]>
…mpversion.cfg) Co-authored-by: Borda <[email protected]>
Co-authored-by: willingc <[email protected]>
b5279fc to
656f5b4
Compare
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Borda.
Consolidates all packaging configuration from legacy files (
setup.py,pytest.ini,tox.ini,.bumpversion.cfg) intopyproject.tomlfollowing PEP 517/518.What does this PR do?
This PR modernizes the packaging configuration by migrating all settings from legacy configuration files to a single
pyproject.tomlfile, following modern Python packaging standards (PEP 517/518). The branch has been rebased on main to maintain a clean commit history and resolve conflicts with recent dependency and configuration updates.Configuration Migration
setup.pyto[project]section[tool.pytest.ini_options][tool.tox]withlegacy_tox_iniformat[tool.bumpversion]Build Process
python -m buildinstead of deprecatedsetup.py sdist bdist_wheelDocumentation
docs/extending-entry-points.rstwith pyproject.toml examples for custom I/O handlers and enginesDEVELOPMENT_GUIDE.mdrelease instructions to use modern build toolsCleanup
MANIFEST.into exclude removed filesDependency Updates (aligned with main branch)
ansicolorsdependency (aligned with removal ofcolorsimport in codebase)pyarrow>=2.0(hdfs) andPyGithub>=1.55(github) todevandtestoptional dependenciesGit History
Example
Entry points are now declared in pyproject.toml:
Instead of setup.py:
Fixes #833
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.