Skip to content

Conversation

@chrysn
Copy link
Contributor

@chrysn chrysn commented Oct 23, 2025

mbedtls headers changed a lot; all are listed, but some that depend on build-time configuration are explicitly commented out. I left them in there because I expect that next time mbed is updated, someone will like me populate this from ls .../*/*.h and then sift through what works and what not.


I couldn't really test this yet, because I'm working with the DECT network-core firmware, exposing which is probably a follow-up. I hope the changes in here are useful at least as a starting point for if/when someone wants to use the more established (and thus testable) features of this crate with the later version.

mbedtls headers changed a lot; all are listed, but some that depend on
build-time configuration are explicitly commented out.
@diondokter diondokter self-requested a review October 24, 2025 09:56
@diondokter
Copy link
Contributor

Hey, thanks for this!

I'm not sure if there's anybody out there using the mbed stuff from this crate.
So it's probably fine like you have it now.

One thing though is that the version of this crate (roughly) tracks the version of the nrfxlib. This limits what we can do with this crate a lot.

We could:

  • Let that go and document it
  • Keep doing it. I can accept this PR, but if there's gonna be a follow-up I'd wait for that instead of releasing

So far we've been doing the latter, but I've personally never liked it much. But there's not been a good reason yet to stop it.

I'm personally also very curious about what you're doing with DECT. Is it gonna be open source?

@jonathanpallant
Copy link
Member

The openssl-sys crate uses an x.y.z+a.b.c number approach, where x is the OpenSSL major version (e.g. '300' for 3.0.0), a.b.c is the OpenSSL version being wrapped and y.z represent patches to the Rust side.

@jonathanpallant
Copy link
Member

I'd vote for merging this now, because it's fine, and save the release for when we have evidence that it's working in an application.

I don't currently have any applications I could use to test this.

@diondokter diondokter merged commit 9c51642 into nrf-rs:develop Oct 24, 2025
1 check passed
@chrysn chrysn deleted the v302 branch October 29, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants