feat: workflow support #68
Conversation
|
#43 This will add the Workflow support |
|
@Cliftonz request for review & merge |
|
@mahendraHegde Can you look at this? |
mahendraHegde
left a comment
mahendraHegde
left a comment
There was a problem hiding this comment.
@srikanth597 plz test all methods in your local against live server using your novu account, some of these methods are breaking
| return &resp, nil | ||
| } | ||
|
|
||
| func (w *WorkflowService) Create(ctx context.Context, request WorkflowData) (*WorkflowData, error) { |
There was a problem hiding this comment.
its ideal to create WorkFlowCreatePayload in model and use it here, otherwise the sdk method signature would confuse the users, asWorkflowData is a superset of the create payload
| return &resp, nil | ||
| } | ||
|
|
||
| func (w *WorkflowService) Update(ctx context.Context, key string, request WorkflowData) (*WorkflowData, error) { |
| Data bool `json:"data"` | ||
| } | ||
|
|
||
| type WorkflowUpdateStatus struct { |
There was a problem hiding this comment.
| type WorkflowUpdateStatus struct { | |
| type WorkflowUpdateStatusPayload struct { |
| PreferenceSettings Channel `json:"preferenceSettings"` | ||
| Critical bool `json:"critical"` | ||
| Tags []string `json:"tags"` | ||
| Steps []interface{} `json:"steps"` |
There was a problem hiding this comment.
any reason for keeping all these as interface, its ideal to have them as concrete structs gives better DX for the sdk users
| BlueprintId string `json:"blueprintId,omitempty"` | ||
| } | ||
| type WorkflowGetResponse struct { | ||
| Data WorkflowData `json:"data"` |
There was a problem hiding this comment.
| Data WorkflowData `json:"data"` | |
| Data []WorkflowData `json:"data"` |
swagger seems to have wrong response structure list returns array of workflows, it was failing to unmarshal when i treied to test locally, can you test all workflow methods once, swagger doesnt seem 100% accurate
There was a problem hiding this comment.
Can you put in an issue on the main repo?
| return &resp, nil | ||
| } | ||
|
|
||
| func (w *WorkflowService) Get(ctx context.Context, key string) (*WorkflowData, error) { |
There was a problem hiding this comment.
response type is not WorkflowData itself its wrapped inside data
There was a problem hiding this comment.
same for update and updateStatus
| WorkflowIntegrationStatus interface{} `json:"workflowIntegrationStatus,omitempty"` | ||
| BlueprintId string `json:"blueprintId,omitempty"` | ||
| } | ||
| type WorkflowGetResponse struct { |
There was a problem hiding this comment.
| type WorkflowGetResponse struct { | |
| type WorkflowListResponse struct { |
| return &resp, nil | ||
| } | ||
|
|
||
| func (w *WorkflowService) UpdateStatus(ctx context.Context, key string) (*WorkflowData, error) { |
There was a problem hiding this comment.
its not accepting status? which is required in the api, so this is failing also
3 participants
No description provided.