-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
meta: new proposal for imports #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the ESLint import ordering rules to separate type-only imports into their own distinct group, improving code organization and readability across the entire codebase. The change adds 'object' and 'type' groups to the import ordering configuration while removing the 'unknown' group.
Key Changes
- Modified ESLint configuration to include 'object' and 'type' import groups
- Reorganized imports in 150+ files to separate type imports from regular imports
- Added consistent blank line separation between import groups throughout the codebase
Reviewed changes
Copilot reviewed 247 out of 247 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eslint.config.js | Added 'object' and 'type' groups to import ordering, removed 'unknown' group |
| packages/ui-components/src/**/*.tsx | Reorganized imports to separate type imports from regular imports |
| apps/site/**/*.ts(x) | Applied consistent import grouping with type imports in separate blocks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8362 +/- ##
==========================================
+ Coverage 76.22% 76.41% +0.18%
==========================================
Files 118 118
Lines 9903 9928 +25
Branches 337 334 -3
==========================================
+ Hits 7549 7586 +37
+ Misses 2352 2340 -12
Partials 2 2 ☔ View full report in Codecov by Sentry. |
canerakdas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM✨
This PR updates our ESLint rules in a way that type imports are their own group and cleanses a bit the groupped imports.