Skip to content

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Nov 25, 2025

Tests should run with the node exe built in the specified BUILDTYPE.

This depends on #60806.

Refs: #60806 (comment)

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 25, 2025
@legendecas legendecas marked this pull request as draft November 25, 2025 12:05
@legendecas legendecas marked this pull request as ready for review November 25, 2025 12:07
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.03%. Comparing base (fc203b3) to head (283ff98).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60850      +/-   ##
==========================================
- Coverage   88.55%   88.03%   -0.53%     
==========================================
  Files         703      703              
  Lines      208259   208259              
  Branches    40178    40086      -92     
==========================================
- Hits       184425   183338    -1087     
- Misses      15855    16873    +1018     
- Partials     7979     8048      +69     

see 96 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas force-pushed the embed-debug branch 2 times, most recently from e7de0f6 to c03895a Compare November 25, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants