-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
crypto: fix DOMException name for non-extractable key error #60830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panva
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
panva:fix-domexception-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
Collaborator
Member
Author
|
cc @nodejs/tsc for
semver-major
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60830 +/- ##
==========================================
- Coverage 88.55% 88.55% -0.01%
==========================================
Files 703 703
Lines 208259 208259
Branches 40164 40175 +11
==========================================
- Hits 184432 184416 -16
- Misses 15823 15857 +34
+ Partials 8004 7986 -18
🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Nov 23, 2025
lpinca
approved these changes
Nov 23, 2025
LiviaMedeiros
approved these changes
Nov 24, 2025
cjihrig
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
confirmed-bug
Issues with confirmed bugs.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
semver-major
PRs that contain breaking changes and should be released in the next major version.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per step 7 in https://w3c.github.io/webcrypto/#SubtleCrypto-method-exportKey