fix: fix workspaces member #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry I fixed it! |
Member
|
Im afraid this change will be ovewritten during deps update |
Member
|
Yeap, I’ll take a look on Monday (I’ll be flying over the weekend) |
Member
|
@re-taro maybe we could write it as a |
kdy1
suggested changes
Nov 26, 2025
Member
kdy1
left a comment
kdy1
left a comment
There was a problem hiding this comment.
➜ swc git:(fix/swc) ✗ cargo check
error: failed to load manifest for workspace member `/Users/kdy1/projects/amaro/deps/swc/bindings/binding_core_node`
referenced via `bindings/*` by workspace at `/Users/kdy1/projects/amaro/deps/swc/Cargo.toml`
Caused by:
failed to parse manifest at `/Users/kdy1/projects/amaro/deps/swc/bindings/binding_core_node/Cargo.toml`
Caused by:
error inheriting `backtrace` from workspace root manifest's `workspace.dependencies.backtrace`
Caused by:
`dependency.backtrace` was not found in `workspace.dependencies`
I think it's using an old version of SWC clone?
Member
See #333 |
kdy1
suggested changes
Nov 26, 2025
Member
kdy1
left a comment
kdy1
left a comment
There was a problem hiding this comment.
This PR has a problem even if I rebase to the relevant branch.
➜ swc git:(fix/swc) ✗ cargo check
error: failed to load manifest for workspace member `/Users/kdy1/projects/amaro/deps/swc/bindings/binding_core_node`
referenced via `bindings/*` by workspace at `/Users/kdy1/projects/amaro/deps/swc/Cargo.toml`
Caused by:
failed to load manifest for dependency `swc_core`
Caused by:
failed to read `/Users/kdy1/projects/amaro/deps/swc/crates/swc_core/Cargo.toml`
Caused by:
No such file or directory (os error 2)
This is not a correct direction either. Why are you trying to do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #329