Skip to content

Conversation

@bandithedoge
Copy link
Contributor

Description

Fixes #7297. Mirrors NixOS/nixpkgs@68543ba.

I'm not sure how to do test cases that don't have to be manually updated along with Starship. Is it alright to use IFD in the test and compare attrsets parsed from TOML?

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@github-actions github-actions bot added the shell label Nov 25, 2025
Copy link
Collaborator

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a crucial setting so it's fine if not tested. IFD in tests would be fine I beleive. If someone can confirm it works, we can merge as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support programs.starship.preset to use official Starship presets

2 participants