fix(core): Drop non-pooling sqlite driver #22280

ivov · 2025-11-25T12:01:57Z

cubic-dev-ai

3 issues found across 9 files

Prompt for AI agents (all 3 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/@n8n/config/src/configs/__tests__/database.config.test.ts">

<violation number="1" location="packages/@n8n/config/src/configs/__tests__/database.config.test.ts:25">
`poolSize` defaults to 3, so this test falsely assumes a default of 1 and will always fail.</violation>

<violation number="2" location="packages/@n8n/config/src/configs/__tests__/database.config.test.ts:37">
`config.poolSize = -1` never throws, so this test is guaranteed to fail.</violation>
</file>

<file name="packages/@n8n/db/src/connection/db-connection-options.ts">

<violation number="1" location="packages/@n8n/db/src/connection/db-connection-options.ts:89">
Rule violated: **Tests**

Community PR Guidelines §2 require PRs to include tests covering core changes. The new default pooled SQLite connection (type `&#39;sqlite-pooled&#39;`) lacks an updated unit test—existing tests still expect the legacy `&#39;sqlite&#39;` driver when poolSize is 0—so the critical DB selection change is currently untested. Update the sqlite connection tests to assert the new default pooled behavior (including poolSize edge cases).</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

cubic-dev-ai · 2025-11-25T12:14:03Z

packages/@n8n/config/src/configs/__tests__/database.config.test.ts

+			}).toThrow();
+		});
+
+		test('should reject negative pool size', () => {


config.poolSize = -1 never throws, so this test is guaranteed to fail.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/@n8n/config/src/configs/__tests__/database.config.test.ts, line 37: <comment>`config.poolSize = -1` never throws, so this test is guaranteed to fail.</comment> <file context> @@ -1,39 +1,51 @@ + }).toThrow(); + }); + + test('should reject negative pool size', () => { + const config = Container.get(SqliteConfig); + expect(() => { </file context>

✅ Addressed in f91f3e6

cubic-dev-ai · 2025-11-25T12:14:03Z

packages/@n8n/config/src/configs/__tests__/database.config.test.ts

+			expect(config.poolSize).toBe(3);
+		});
+
+		test('should accept pool size of 1', () => {


poolSize defaults to 3, so this test falsely assumes a default of 1 and will always fail.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/@n8n/config/src/configs/__tests__/database.config.test.ts, line 25: <comment>`poolSize` defaults to 3, so this test falsely assumes a default of 1 and will always fail.</comment> <file context> @@ -1,39 +1,51 @@ + expect(config.poolSize).toBe(3); + }); + + test('should accept pool size of 1', () => { + const config = Container.get(SqliteConfig); + expect(config.poolSize).toBe(1); </file context>

✅ Addressed in f91f3e6

cubic-dev-ai · 2025-11-25T12:14:03Z

packages/@n8n/db/src/connection/db-connection-options.ts

-			};
-		}
+		return {
+			type: 'sqlite-pooled',


Rule violated: Tests

Community PR Guidelines §2 require PRs to include tests covering core changes. The new default pooled SQLite connection (type 'sqlite-pooled') lacks an updated unit test—existing tests still expect the legacy 'sqlite' driver when poolSize is 0—so the critical DB selection change is currently untested. Update the sqlite connection tests to assert the new default pooled behavior (including poolSize edge cases).

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/@n8n/db/src/connection/db-connection-options.ts, line 89: <comment>Community PR Guidelines §2 require PRs to include tests covering core changes. The new default pooled SQLite connection (type `'sqlite-pooled'`) lacks an updated unit test—existing tests still expect the legacy `'sqlite'` driver when poolSize is 0—so the critical DB selection change is currently untested. Update the sqlite connection tests to assert the new default pooled behavior (including poolSize edge cases).</comment> <file context> @@ -85,22 +85,14 @@ export class DbConnectionOptions { - }; - } + return { + type: 'sqlite-pooled', + poolSize: sqliteConfig.poolSize, + enableWAL: true, </file context>

codecov · 2025-11-25T12:18:47Z

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...s/@n8n/db/src/repositories/execution.repository.ts	0.00%	3 Missing ⚠️
...ckages/@n8n/db/src/repositories/role.repository.ts	0.00%	1 Missing ⚠️
packages/cli/src/server.ts	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

currents-bot · 2025-11-25T17:18:09Z

✅

E2E Tests: n8n tests passed after 9m 31.9s

🟢 588 · 🔴 0 · ⚪️ 12 · 🟣 3

View Run Details

Run Details

Project: n8n
Groups: 2
Framework: Playwright
Run Status: Passed
Commit: 90822e9
Spec files: 96
Overall tests: 600
Duration: 9m 31.9s
Parallelization: 9

Groups

GroupId	Results	Spec Files Progress
ui	🟢 539 · 🔴 0 · ⚪️ 12 · 🟣 3	90 / 90
ui:isolated	🟢 49 · 🔴 0 · ⚪️ 0	6 / 6

This message was posted automatically by currents.dev | Integration Settings

tomi

Can we keep the changes to minimum until we actually merge the v2-dev branch to avoid conflicts as much as possible? The branch is somewhat long-lived with a lot of incoming changes, so there's a potential risk of having to deal with conflicts. We could leave isLegacySqlite for now on the database.config.ts but hardcode it to false. We can then cleanup after we have merged the dev branch

ivov · 2025-11-26T11:34:49Z

Can we keep the changes to minimum until we actually merge the v2-dev branch to avoid conflicts as much as possible? The branch is somewhat long-lived with a lot of incoming changes, so there's a potential risk of having to deal with conflicts. We could leave isLegacySqlite for now on the database.config.ts but hardcode it to false. We can then cleanup after we have merged the dev branch

Oh I wasn't aware of this. I thought the plan was to merge next week already. I'll redo it then.

fix(core): Drop non-pooling sqlite driver

d4cce46

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 25, 2025

Remove more uses

c1f5bc3

cubic-dev-ai bot reviewed Nov 25, 2025

View reviewed changes

ivov added the v2-prep label Nov 25, 2025

This comment has been minimized.

Sign in to view

ivov added 5 commits November 25, 2025 13:36

Remove more uses

df92961

Another spot

487c1da

Update tests

f91f3e6

Remove stale comment

4b15f06

Remove redundant tests

6fbe353

ivov requested a review from tomi November 25, 2025 16:08

ivov added 2 commits November 25, 2025 17:50

Remove unused imports

61de0c9

Fix typecheck

90822e9

tomi reviewed Nov 25, 2025

View reviewed changes

ivov closed this Nov 26, 2025

ivov mentioned this pull request Nov 26, 2025

fix(core): Set default for allowed file access dirs #22279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): Drop non-pooling sqlite driver #22280

fix(core): Drop non-pooling sqlite driver #22280

Uh oh!

ivov commented Nov 25, 2025

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Nov 25, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Nov 25, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Nov 25, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

currents-bot bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

tomi left a comment

Uh oh!

ivov commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(core): Drop non-pooling sqlite driver #22280

fix(core): Drop non-pooling sqlite driver #22280

Uh oh!

Conversation

ivov commented Nov 25, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

currents-bot bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomi left a comment

Choose a reason for hiding this comment

Uh oh!

ivov commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cubic-dev-ai bot Nov 25, 2025 •

edited

Loading

cubic-dev-ai bot Nov 25, 2025 •

edited

Loading

cubic-dev-ai bot Nov 25, 2025 •

edited

Loading

codecov bot commented Nov 25, 2025 •

edited

Loading

currents-bot bot commented Nov 25, 2025 •

edited

Loading