-
Notifications
You must be signed in to change notification settings - Fork 51k
New files from Fly.io Launch #22262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New files from Fly.io Launch #22262
Conversation
|
Fly.io seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hey @Pascalchinedu, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: Regarding new nodes: If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach. About review timelines: Thank you again for contributing to n8n. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="Dockerfile">
<violation number="1" location="Dockerfile:28">
`pnpm install` runs before the workspace metadata and packages are copied, so the `workspace:*` dependencies (e.g., `@n8n/eslint-config`) can’t resolve and the Docker build fails. Copy `pnpm-workspace.yaml` and the workspace package manifests (or the full repo) before running `pnpm install`.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| apt-get install --no-install-recommends -y build-essential node-gyp pkg-config python-is-python3 | ||
|
|
||
| # Install node modules | ||
| COPY .npmrc package.json pnpm-lock.yaml ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm install runs before the workspace metadata and packages are copied, so the workspace:* dependencies (e.g., @n8n/eslint-config) can’t resolve and the Docker build fails. Copy pnpm-workspace.yaml and the workspace package manifests (or the full repo) before running pnpm install.
Prompt for AI agents
Address the following comment on Dockerfile at line 28:
<comment>`pnpm install` runs before the workspace metadata and packages are copied, so the `workspace:*` dependencies (e.g., `@n8n/eslint-config`) can’t resolve and the Docker build fails. Copy `pnpm-workspace.yaml` and the workspace package manifests (or the full repo) before running `pnpm install`.</comment>
<file context>
@@ -0,0 +1,49 @@
+ apt-get install --no-install-recommends -y build-essential node-gyp pkg-config python-is-python3
+
+# Install node modules
+COPY .npmrc package.json pnpm-lock.yaml ./
+RUN pnpm install --frozen-lockfile --prod=false
+
</file context>
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)