-
Notifications
You must be signed in to change notification settings - Fork 50.9k
feat(Gemini Node): Add support for Nano Banana Pro model #22254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Gemini Node): Add support for Nano Banana Pro model #22254
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 4 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts">
<violation number="1" location="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts:147">
Fetching `modelId` without a fallback leaves existing workflows with an empty model string, turning the request into `/v1beta/:generateContent` and causing the node to fail. Preserve the prior default model when no selection has been made.</violation>
<violation number="2" location="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts:147">
Rule violated: **Tests**
Community PR Guidelines §2 require node changes to include tests. The new image-edit path now depends on the user-selected `modelId`, but none of the Gemini image edit tests exercise or assert that parameter, leaving the added functionality untested. Please update the tests (e.g., edit.operation.test.ts) to cover retrieving `modelId` and passing it to the API.</violation>
</file>
<file name="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/methods/listSearch.ts">
<violation number="1" location="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/methods/listSearch.ts:87">
Filtering image edit models by the "Nano Banana" label fails because the filter is consumed before the labels are appended, so searching for "Nano" yields no results. Apply the filter after decorating the names so users can search by the visible label.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts
Outdated
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/methods/listSearch.ts
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts
Outdated
Show resolved
Hide resolved
|
E2E Tests: n8n tests passed after 7m 46.4s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
ShireenMissi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works as expected 🎉
Summary
Add support for Nano Banana Pro model for image generation and image editing
gemini-3-pro-image-previewmodelRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3995/add-support-for-nano-banana-pro-in-gemini-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)