Skip to content

Conversation

@RomanDavydchuk
Copy link
Contributor

Summary

Add support for Nano Banana Pro model for image generation and image editing

  • Image generation: updated the RLC to not filter out the new gemini-3-pro-image-preview model
  • Image editing: added a RLC that shows the "Nano Banana" models

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-3995/add-support-for-nano-banana-pro-in-gemini-node

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Nov 24, 2025
@RomanDavydchuk RomanDavydchuk marked this pull request as ready for review November 24, 2025 19:40
@Joffcom Joffcom requested a review from ShireenMissi November 24, 2025 19:40
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 4 files

Prompt for AI agents (all 3 issues)

Understand the root cause of the following 3 issues and fix them.


<file name="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts">

<violation number="1" location="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts:147">
Fetching `modelId` without a fallback leaves existing workflows with an empty model string, turning the request into `/v1beta/:generateContent` and causing the node to fail. Preserve the prior default model when no selection has been made.</violation>

<violation number="2" location="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/actions/image/edit.operation.ts:147">
Rule violated: **Tests**

Community PR Guidelines §2 require node changes to include tests. The new image-edit path now depends on the user-selected `modelId`, but none of the Gemini image edit tests exercise or assert that parameter, leaving the added functionality untested. Please update the tests (e.g., edit.operation.test.ts) to cover retrieving `modelId` and passing it to the API.</violation>
</file>

<file name="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/methods/listSearch.ts">

<violation number="1" location="packages/@n8n/nodes-langchain/nodes/vendors/GoogleGemini/methods/listSearch.ts:87">
Filtering image edit models by the &quot;Nano Banana&quot; label fails because the filter is consumed before the labels are appended, so searching for &quot;Nano&quot; yields no results. Apply the filter after decorating the names so users can search by the visible label.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@currents-bot
Copy link

currents-bot bot commented Nov 24, 2025

E2E Tests: n8n tests passed after 7m 46.4s

🟢 588 · 🔴 0 · ⚪️ 12 · 🟣 4

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 027ab28

  • Spec files: 96

  • Overall tests: 600

  • Duration: 7m 46.4s

  • Parallelization: 9

Groups

GroupId Results Spec Files Progress
ui 🟢 539 · 🔴 0 · ⚪️ 12 · 🟣 4 90 / 90
ui:isolated 🟢 49 · 🔴 0 · ⚪️ 0 6 / 6


This message was posted automatically by currents.dev | Integration Settings

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as expected 🎉

@ShireenMissi ShireenMissi merged commit 7a4cc40 into master Nov 26, 2025
44 checks passed
@ShireenMissi ShireenMissi deleted the node-3995-add-support-for-nano-banana-pro-in-gemini-node branch November 26, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants