Skip to content

fix(editor): Allow running webhook workflow even when a node has error #22239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+500 −9
Open

fix(editor): Allow running webhook workflow even when a node has error #22239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/frontend/editor-ui/src/app/composables/useRunWorkflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,17 +209,15 @@ describe('useRunWorkflow({ router })', () => {
expect(workflowsStore.executionWaitingForWebhook).toBe(false);
});

it('should prevent running a webhook-based workflow that has issues', async () => {
it('should not prevent running a webhook-based workflow that has issues', async () => {
const { runWorkflowApi } = useRunWorkflow({ router });
vi.mocked(workflowsStore).nodesIssuesExist = true;
vi.mocked(workflowsStore).runWorkflow.mockResolvedValue({
executionId: '123',
waitingForWebhook: true,
});

await expect(runWorkflowApi({} as IStartRunData)).rejects.toThrow(
'workflowRun.showError.resolveOutstandingIssues',
);
expect(async () => await runWorkflowApi({} as IStartRunData)).not.toThrow();

vi.mocked(workflowsStore).nodesIssuesExist = false;
});
Expand Down
11 changes: 6 additions & 5 deletions packages/frontend/editor-ui/src/app/composables/useRunWorkflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,6 @@ export function useRunWorkflow(useRunWorkflowOpts: {
workflowState.setActiveExecutionId(response.executionId);
}

if (response.waitingForWebhook === true && workflowsStore.nodesIssuesExist) {
workflowState.setActiveExecutionId(undefined);
throw new Error(i18n.baseText('workflowRun.showError.resolveOutstandingIssues'));
}

if (response.waitingForWebhook === true) {
workflowsStore.executionWaitingForWebhook = true;
}
Expand Down Expand Up @@ -377,6 +372,12 @@ export function useRunWorkflow(useRunWorkflowOpts: {
workflowState.setWorkflowExecutionData(executionData);
nodeHelpers.updateNodesExecutionIssues();

const triggerNodeName = triggerToStartFrom?.name ?? '';
const triggerNode = workflowsStore.getNodeByName(triggerNodeName);
if (triggerNode && workflowsStore.nodeHasIssuesDownstream(triggerNode.name)) {
throw new Error(i18n.baseText('workflowRun.showError.resolveOutstandingIssues'));
}

useDocumentTitle().setDocumentTitle(workflowObject.value.name as string, 'EXECUTING');
const runWorkflowApiResponse = await runWorkflowApi(startRunData);
const pinData = workflowData.pinData ?? {};
Expand Down
Loading
Loading