(brwells) Add temporary forecast datasets #8504
+37
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| friendly_name: Temporary Forecasts | ||
| description: |- | ||
| Temporary dataset pending a conversation on naming conventions. Use at your own risk. | ||
| Views on forecasts based on Firefox data and external models. Forecast views may also live in other datasets related to the products they support. | ||
| dataset_base_acl: view | ||
| user_facing: true | ||
| labels: {} | ||
| default_table_workgroup_access: | ||
| - role: roles/bigquery.dataViewer | ||
| members: | ||
| - workgroup:mozilla-confidential | ||
| default_table_expiration_ms: null | ||
| workgroup_access: | ||
| - role: roles/bigquery.dataViewer | ||
| members: | ||
| - workgroup:mozilla-confidential | ||
|
Contributor
There was a problem hiding this comment. I did not mean we necessarily have to call this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| friendly_name: Temporary Forecasts Derived | ||
| description: |- | ||
| Temporary dataset pending a conversation on naming conventions. Use at your own risk. | ||
| Forecasts based on Firefox data and external models, plus related secondary tables. Writable by the Outerbounds default perimeter. | ||
brendanwells-moz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| This dataset combines forecasts across products; forecasts may also live in other datasets related to the products they support. | ||
| dataset_base_acl: derived | ||
| user_facing: false | ||
| labels: {} | ||
| default_table_workgroup_access: | ||
|
Contributor
There was a problem hiding this comment. @scholtzan if I remember correctly we should not be specifying
Contributor
There was a problem hiding this comment. We can remove bigquery-etl/bigquery_etl/metadata/parse_metadata.py Lines 20 to 23 in 164f88c |
||
| - role: roles/bigquery.dataViewer | ||
| members: | ||
| - workgroup:mozilla-confidential | ||
| default_table_expiration_ms: null | ||
| workgroup_access: | ||
| - role: roles/bigquery.dataViewer | ||
| members: | ||
| - workgroup:mozilla-confidential | ||
brendanwells-moz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - workgroup:dataops-managed/external-outerbounds-task-default | ||
| - role: roles/bigquery.dataEditor | ||
| members: | ||
| - workgroup:dataops-managed/external-outerbounds-task-default | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove
default_table_workgroup_accesshere:bigquery-etl/bigquery_etl/metadata/parse_metadata.py
Lines 20 to 23 in 164f88c