Skip to content

Conversation

@kwindau
Copy link
Contributor

@kwindau kwindau commented Nov 25, 2025

Description

This PR adds the following columns on to the view mozdata.firefox_desktop.clients_first_seen_28_days_later:

  • funnel_derived
  • distribution_model
  • partner_org
  • is_desktop

Related Tickets & Documents

Reviewer, please follow this checklist

@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

@kwindau kwindau marked this pull request as ready for review November 28, 2025 22:19
@dataops-ci-bot

This comment has been minimized.

@kwindau kwindau requested a review from SuYoungHong November 29, 2025 00:40
@kwindau kwindau enabled auto-merge December 1, 2025 21:39
@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into add-cols-cfs-28-day-later-view"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/clients_first_seen_28_days_later/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/clients_first_seen_28_days_later/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/clients_first_seen_28_days_later/view.sql	2025-12-01 21:36:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/clients_first_seen_28_days_later/view.sql	2025-12-01 21:33:52.000000000 +0000
@@ -2,6 +2,23 @@
   `moz-fx-data-shared-prod.firefox_desktop.clients_first_seen_28_days_later`
 AS
 SELECT
-  *
+  cfs28.*,
+  `moz-fx-data-shared-prod`.udf.funnel_derived_clients(
+    normalized_os,
+    first_seen_date,
+    app_build_id,
+    attribution_source,
+    attribution_ua,
+    startup_profile_selection_reason,
+    distribution_id
+  ) AS funnel_derived,
+  `moz-fx-data-shared-prod`.udf.distribution_model_clients(distribution_id) AS distribution_model,
+  `moz-fx-data-shared-prod`.udf.partner_org_clients(distribution_id) AS partner_org,
+  IF(
+    LOWER(IFNULL(isp_name, '')) <> "browserstack"
+    AND LOWER(IFNULL(distribution_id, '')) <> "mozillaonline",
+    TRUE,
+    FALSE
+  ) AS is_desktop
 FROM
-  `moz-fx-data-shared-prod.firefox_desktop_derived.clients_first_seen_28_days_later_v1`
+  `moz-fx-data-shared-prod.firefox_desktop_derived.clients_first_seen_28_days_later_v1` cfs28

Link to full diff

@kwindau kwindau added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 736dda5 Dec 1, 2025
22 checks passed
@kwindau kwindau deleted the add-cols-cfs-28-day-later-view branch December 1, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants