-
Notifications
You must be signed in to change notification settings - Fork 125
DENG-10202 Changed geo deprecation to opt out config #8498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| table = client.get_table(live_table) | ||
|
|
||
| # only glean tables have this label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we're explicitly only doing this for glean apps? I don't remember if this was discussed already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we are only deprecating the geo fields for glean apps for now. After the glean migration is completed the legacy tables would be deprecated.
Co-authored-by: Ben Wu <[email protected]>
Co-authored-by: Ben Wu <[email protected]>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Ben Wu <[email protected]>
Integration report for "Updated ref to mapping method"
|
Description
The current set up from #8362 uses an
opt-inlist to deprecate geo (cityandsubdivision) fields.This PR changes the set up to use an
opt-outapproach to exempt specific apps and tables. In this case, any apps not listed in the config file (including future apps added) will have geo fields deprecated by default.Related Tickets & Documents
Reviewer, please follow this checklist