-
Notifications
You must be signed in to change notification settings - Fork 125
feat(DENG-9505): migrating amo datasets to glean #8358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kik-kik
wants to merge
9
commits into
main
Choose a base branch
from
feat/DENG-9505/migrating-amo-datasets-to-glean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39818f0 to
2f7f532
Compare
This comment has been minimized.
This comment has been minimized.
469c157 to
18f4220
Compare
This comment has been minimized.
This comment has been minimized.
18f4220 to
fd11eaa
Compare
This comment has been minimized.
This comment has been minimized.
69da033 to
fc1469b
Compare
This comment has been minimized.
This comment has been minimized.
f7091b5 to
cee066b
Compare
This comment has been minimized.
This comment has been minimized.
… inside amo_glean_derived
cee066b to
376b25c
Compare
This comment has been minimized.
This comment has been minimized.
…y_concat returns data even when addons_active_addons is empty but addons_theme is not
Integration report for "fix: make sure active_addons length is more than 0 and make sure array_concat returns data even when addons_active_addons is empty but addons_theme is not"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(DENG-9505): migrating amo datasets to glean
This PR introduces the following changes:
stats_installtofirefox_desktop_stats_installsto better represent the contents of the dataset (desktop date).desktop_addons_by_clienttofirefox_desktop_addons_by_clientsfor consistency.firefox_desktop_stats_installsto use Glean instead of legacy telemetry.firefox_desktop_addons_by_clientsto use Glean instead of legacy telemetry.Things still to do:
This is a first step towards migrating amo data to use Glean, steps that will follow after this PR include:
amo_prodto point to the new views (for backwards compatibility).