-
Notifications
You must be signed in to change notification settings - Fork 14
Lazy provider #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy provider #204
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
9330966 to
bb84b98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new LazyProvider feature that enables lazy loading of providers through import strings, addressing circular dependency issues between containers. The main change removes the abc.ABC inheritance from SupportsContext to support proper multiple inheritance, and adds comprehensive implementation and testing of the lazy provider functionality.
- Implements
LazyProviderclass for lazy importing of providers using string-based references - Refactors
SupportsContextto removeabc.ABCinheritance and fixes MRO issues inBaseContainerMeta - Adds version constraint for faststream dependency
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| that_depends/providers/context_resources.py | Removes abc.ABC inheritance from SupportsContext to enable proper multiple inheritance |
| that_depends/meta.py | Reorders parent classes in BaseContainerMeta to fix MRO with updated SupportsContext |
| that_depends/experimental/providers.py | Implements new LazyProvider class with full provider protocol support |
| that_depends/experimental/init.py | Exports LazyProvider from experimental module |
| tests/experimental/test_lazy_provider.py | Adds validation tests for LazyProvider initialization |
| tests/experimental/test_container_2.py | Adds comprehensive integration tests for lazy provider functionality |
| tests/experimental/test_container_1.py | Adds circular dependency test case |
| pyproject.toml | Adds version constraint for faststream dependency |
| mkdocs.yml | Adds documentation navigation for lazy provider |
| docs/experimental/lazy.md | Adds user documentation for lazy provider feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bb84b98 to
d17ba52
Compare
Resolves #203