Add OSC8 hyperlink support #1360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the specification described in https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda, add hyperlink support to mosh. Closes mobile-shell#1245
Collaborator
|
For us to consider merging this it needs to have test coverage. |
Author
|
That's a fair cop. I didn't immediately find the test suite but now I have I will take a crack at it. |
eminence
reviewed
Nov 26, 2025
Comment on lines
+622
to
+624
| if ( id_pos != std::string::npos ) { | ||
| id = params.substr( id_pos + 3, params.find( ":", id_pos + 3 ) ); | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure this right. Consider what happens if there's two key/value pairs in params:
id=123:foo=bar
id_pos is 0, and params.find(":", id_pos + 3) is 6.
So then id becomes params.substr(3, 6) which is 123:fo
(The second argument to std::string::substr is length of the substring, not the final character position)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the specification described in https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda, add hyperlink support to mosh.
Closes #1245