Fix showRange field regression in InlineCompletionItem #279269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree company="Meta" |
Copilot finished reviewing on behalf of
yanmofeixi
November 25, 2025 03:14
yanmofeixi
force-pushed
the
fix/restore-showrange-functionality
branch
from
1d84234 to
e4d827f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the showRange functionality for inline completions that was accidentally removed during the InlineCompletionsSource refactoring. The showRange field allows extensions to specify a range within which inline completions should be visible, hiding them when the cursor moves outside this range.
Key changes:
- Added
showRangeparameter toInlineSuggestDataconstructor and passed it through the data flow - Implemented
showRangevisibility check inInlineCompletionItem.isVisible() - Added cursor position validation against
showRangein the inline edit state computation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts |
Added showRange field to InlineSuggestData constructor and passed it from InlineCompletion to InlineSuggestData in toInlineSuggestData() |
src/vs/editor/contrib/inlineCompletions/browser/model/inlineSuggestionItem.ts |
Added showRange getter to InlineSuggestionItemBase and implemented visibility check in InlineCompletionItem.isVisible() |
src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts |
Added cursor position check against showRange for inline edits in the state computation |
src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts
Show resolved
Hide resolved
yanmofeixi
force-pushed
the
fix/restore-showrange-functionality
branch
from
e4d827f to
9df68fb
Compare
The showRange field in InlineCompletionItem (part of the inlineCompletionsAdditions proposed API) stopped working after the InlineCompletionsSource refactoring in commit b0abf06. While the field is still defined in the API and accepted from extensions, the implementation that checks cursor position against this range was removed. This commit restores the showRange functionality by: 1. Adding showRange field to InlineSuggestData constructor 2. Passing showRange from InlineCompletion to InlineSuggestData in toInlineSuggestData 3. Adding showRange getter to InlineSuggestionItemBase 4. Implementing showRange check in InlineCompletionItem.isVisible() method 5. Adding cursor position check against showRange in inlineCompletionsModel state computation The fix ensures that inline completions are only shown when the cursor is within the specified showRange (if provided), matching the original behavior from PR microsoft#237532. Fixes regression from commit b0abf06 (Refactors InlineCompletionsSource) Restores functionality from commit a016c0b (Support show range for inline edits)
yanmofeixi
force-pushed
the
fix/restore-showrange-functionality
branch
from
60d5648 to
181088e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The showRange field in InlineCompletionItem (part of the inlineCompletionsAdditions proposed API) stopped working after the InlineCompletionsSource refactoring in commit b0abf06. While the field is still defined in the API and accepted from extensions, the implementation that checks cursor position against this range was removed.
See more detail: #279266
This commit restores the showRange functionality by:
The fix ensures that inline completions are only shown when the cursor is within the specified showRange (if provided), matching the original behavior from PR #237532.
Fixes regression from commit b0abf06 (Refactors InlineCompletionsSource) Restores functionality from commit a016c0b (Support show range for inline edits)