-
Notifications
You must be signed in to change notification settings - Fork 36.4k
Resolve regression where build task did not start in wsl #279249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds temporary debug logging (prefixed with "MYLOG") to investigate a regression related to current working directory (cwd) behavior in WSL terminals. The logging traces cwd state changes through various lifecycle events in the terminal instance and shell integration addon.
Key Changes
- Added debug logging to track cwd state changes during terminal lifecycle events
- Instrumented shell integration capability addition, command restoration, and process creation
- Logged remote authority and user home information to help diagnose WSL-specific issues
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/browser/terminalInstance.ts | Added 10 debug log statements tracking cwd changes, shell integration setup, and process creation in the terminal instance lifecycle |
| src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts | Added 3 debug log statements tracking cwd updates and command deserialization in the shell integration addon |
(Unexpected Result): Result seem same for both pre+post this PR though. |
Resolves: #275011
TODO: Remove my logs
Long story short, after 975a1ef, we ensure capabilities registered before shell integration events fire.
SOMEHOWShellIntegrationAddon._updatecwd and
onDidChangeCwdwas getting called beforecreateProcessin remote.Whereas, in non-remote, create process happened first, then updateCwd happened.
Edit: Maybe its more suspicious that activeWorkspaceUri is undefined.. for the wsl active workspace case:
Regardless, we were going into
vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
Lines 1539 to 1543 in 51e7119