Skip to content

Conversation

@roblourens
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings November 24, 2025 18:48
@roblourens roblourens enabled auto-merge (squash) November 24, 2025 18:48
@roblourens roblourens self-assigned this Nov 24, 2025
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 24, 2025
Copilot finished reviewing on behalf of roblourens November 24, 2025 18:50
karthiknadig
karthiknadig previously approved these changes Nov 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the configuration setting check for chat.localBackgroundSessions, simplifying the logic that controls whether chat models retain a self-reference to stay alive in the background during request processing. The change removes a user-facing configuration option, making the background keep-alive behavior always enabled for chat sessions (unless explicitly disabled via the disableBackgroundKeepAlive parameter).

  • Removed conditional check for chat.localBackgroundSessions configuration setting
  • Background keep-alive is now always enabled for chat sessions by default

@bpasero
Copy link
Member

bpasero commented Nov 26, 2025

Red CI

karthiknadig
karthiknadig previously approved these changes Nov 28, 2025
@roblourens roblourens merged commit c5e84e2 into main Nov 28, 2025
28 checks passed
@roblourens roblourens deleted the roblou/obvious-orangutan branch November 28, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants