Skip to content

Turn on isolatedModule in tsconfig #279208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −12
Open

Turn on isolatedModule in tsconfig #279208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c868b15
Turn on isolatedModule in tsconfig
bryanchen-d Nov 24, 2025
e7436be
undo unrelated changes
bpasero Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"sourceMap": false,
"allowJs": true,
"resolveJsonModule": true,
"isolatedModules": false,
"isolatedModules": true,
"outDir": "../out/vs",
"types": [
"@webgpu/types",
Expand Down
3 changes: 1 addition & 2 deletions src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@
import { localize } from '../../../../../nls.js';
import { Codicon } from '../../../../../base/common/codicons.js';
import { ThemeIcon } from '../../../../../base/common/themables.js';
import { localChatSessionType } from '../../common/chatSessionsService.js';

export const AGENT_SESSIONS_VIEW_CONTAINER_ID = 'workbench.viewContainer.agentSessions';
export const AGENT_SESSIONS_VIEW_ID = 'workbench.view.agentSessions';

export enum AgentSessionProviders {
Local = localChatSessionType,
Local = 'local',
Background = 'copilotcli',
Cloud = 'copilot-cloud-agent',
}
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { getCleanPromptName } from '../config/promptFileLocations.js';
import { PROMPT_LANGUAGE_ID, PromptsType, getPromptsTypeForLanguageId } from '../promptTypes.js';
import { PromptFilesLocator } from '../utils/promptFilesLocator.js';
import { PromptFileParser, ParsedPromptFile, PromptHeaderAttributes } from '../promptFileParser.js';
import { IAgentInstructions, IAgentSource, IChatPromptSlashCommand, ICustomAgent, IExtensionPromptPath, ILocalPromptPath, IPromptPath, IPromptsService, IClaudeSkill, IUserPromptPath, PromptsStorage } from './promptsService.js';
import { IAgentInstructions, type IAgentSource, IChatPromptSlashCommand, ICustomAgent, IExtensionPromptPath, ILocalPromptPath, IPromptPath, IPromptsService, IClaudeSkill, IUserPromptPath, PromptsStorage } from './promptsService.js';
import { Delayer } from '../../../../../../base/common/async.js';
import { Schemas } from '../../../../../../base/common/network.js';
import { IExtensionService } from '../../../../../services/extensions/common/extensions.js';
Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/chat/common/tools/promptTsxTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* It should be kept in sync with the types in that file.
*/

export declare const enum PromptNodeType {
export const enum PromptNodeType {
Piece = 1,
Text = 2
}
Expand All @@ -23,7 +23,7 @@ export interface TextJSON {
* less descriptive than the actual constructor, as we only care to preserve
* the element data that the renderer cares about.
*/
export declare const enum PieceCtorKind {
export const enum PieceCtorKind {
BaseChatMessage = 1,
Other = 2,
ImageChatMessage = 3
Expand Down
13 changes: 7 additions & 6 deletions ...rkbench/contrib/terminalContrib/chatAgentTools/browser/executeStrategy/executeStrategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,13 @@ export async function waitForIdleWithPromptHeuristics(
}
}

const enum TerminalState {
Initial,
Prompt,
Executing,
PromptAfterExecuting,
}

/**
* Tracks the terminal for being idle on a prompt input. This must be called before `executeCommand`
* is called.
Expand Down Expand Up @@ -182,12 +189,6 @@ export async function trackIdleOnPrompt(
// and the terminal is idle. Note that D is treated as a signal for executed since shell
// integration sometimes lacks the C sequence either due to limitations in the integation or the
// required hooks aren't available.
const enum TerminalState {
Initial,
Prompt,
Executing,
PromptAfterExecuting,
}
store.add(onData(e => {
// Update state
// p10k fires C as `133;C;`
Expand Down
Loading