Skip to content

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Nov 25, 2025

Summary of the Pull Request

This PR pulls out the icon picker used in Profiles_Base.xaml to be its own control. Then it's reused as a way to set an icon on folders in the new tab menu.

As a part of pulling out the icon picker into its own control, some minor code-health polish was added (i.e. lazy loading icon types and built in icons).

The new tab menu didn't have a NavigateToPageArgs, so I took the declaration from #19519 and moved it here. I chose to do that instead of creating a NavigateToNewTabMenuArgs since that's more strict and it would be removed as a part of #19519 anyways.

Aside from that, the PR is pretty straightforward.

References and Relevant Issues

Part of #18281

Validation Steps Performed

  • Profile icon picker
    • set none
    • set built-in icon
    • set emoji
    • set file
    • loads icons properly (for all of the scenarios above)
  • New tab menu folder icon picker
    • set none
    • set built-in icon
    • set emoji
    • set file
    • loads icons properly (for all of the scenarios above)

@carlos-zamora
Copy link
Member Author

Demo

image

@carlos-zamora

This comment was marked as resolved.

@carlos-zamora carlos-zamora marked this pull request as ready for review December 2, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants