-
Notifications
You must be signed in to change notification settings - Fork 14
Fix meeting activity deserialization for Teams PascalCase payloads #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: aacebo <[email protected]>
|
I attest that I have verified |
heyitsaamir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but this seems like a miss from their end..... why would they adopt this deviation from the norm.... Could be worth asking in TeamSid....
|
Also pls raise PRs in the other repos too 🙏🏽 |
|
was this working before? wondering if different Teams client versions, or Rings, might use camelCase for these. We should have a confirmation from backend folks that this is the expected casing. |
|
@rido-min pinged you in teams with the confirmation thread, also confirmed via BF types that its historically been in Pascal case for some reason... not happy about it but platform can't change it cause that would break people @heyitsaamir https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Schema/Teams/MeetingEventDetails.cs#L46 |
|
When it will be fixed? It's blocker for me as stated here: #196 |
|
@AdamJachocki sorry for the wait, we are just creating a sample and verifying the change with our backend team before merging and releasing a fix for this. Thank you for your patience! |
Teams sends meeting start/end events with PascalCase properties in the
valueobject (Id,MeetingType,Title,JoinUrl,StartTime,EndTime), causing deserialization failures.Changes
MeetingStartActivityValueandMeetingEndActivityValueto use PascalCase inJsonPropertyNameattributesExample
{ "name": "application/vnd.microsoft.meetingEnd", "type": "event", "value": { "Id": "MCMx...", // Was: "id" "MeetingType": "Scheduled", // Was: "meetingType" "Title": "Daily Standup", // Was: "title" "JoinUrl": "https://...", // Was: "joinUrl" "EndTime": "2025-10-31..." // Was: "endTime" } }This deviates from the library's camelCase convention but matches the actual Teams platform format.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.