fix: removed unused option PrevTCPSockStats from linux util #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
alexcastilio
requested changes
Nov 17, 2025
letv1nnn
force-pushed
the
fix/remove-unused-prevtcpsockstats
branch
from
2e51689 to
18d903b
Compare
alexcastilio
requested changes
Nov 18, 2025
Contributor
alexcastilio
left a comment
alexcastilio
left a comment
There was a problem hiding this comment.
I see that other commits were added to this PR. Please remove them as they are adding changes that are not relevant here.
letv1nnn
force-pushed
the
fix/remove-unused-prevtcpsockstats
branch
from
465c078 to
f9b6ec4
Compare
letv1nnn
force-pushed
the
fix/remove-unused-prevtcpsockstats
branch
from
f9b6ec4 to
04fb398
Compare
letv1nnn
force-pushed
the
fix/remove-unused-prevtcpsockstats
branch
from
36642c2 to
77d955a
Compare
agrawaliti
pushed a commit
to agrawaliti/retina
that referenced
this pull request
Dec 3, 2025
…t#1924) # Description I removed unused code from linux_util, specifically PrevTCPSockStats. I also added some entries to gitignore including test-summary(generated after make test) and ignoring logs. ## Related Issue This pr related to microsoft#1066 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed I've provided two screenshots, one from make test, another is just linting. testing <img width="1276" height="743" alt="image" src="https://github.com/user-attachments/assets/4a32cf70-fdd7-4bf8-b2c9-15a3f736421e" /> Linting <img width="1280" height="745" alt="image" src="https://github.com/user-attachments/assets/85cce4db-4824-4eb8-861e-7d1ae24787b7" /> ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Co-authored-by: Alex Castilio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed unused code from linux_util, specifically PrevTCPSockStats. I also added some entries to gitignore including test-summary(generated after make test) and ignoring logs.
Related Issue
This pr related to #1066
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
I've provided two screenshots, one from make test, another is just linting.
testing
Linting
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.