-
Notifications
You must be signed in to change notification settings - Fork 865
Allow multiple instances of the same recognizer through YAML #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… using instance names in recognizer configuration
|
Thanks! Would you mind adding a test and example conf for for the test to use? There is a conf folder inside the tests folder. |
|
@Mehrsary please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Yeah, if the overall approach sounds good to you, I'll move it forward and get back to you |
|
@Mehrsary it does look good. We have another PR for input validation so one would need to be merged with the other to make sure the functionality works as expected. I don't mind getting this functionality into the other PR so if you'd like, please add the test cases and we'll merge. Otherwise, we would merge it after the other change. |
|
Please see #1780. It should be handled there but if it isn't, I would suggest to merge 1780 first and add the capability afterwards. Thanks for the work! |
Change Description
Added support for configuring multiple instances of the same recognizer class (e.g., GLiNERRecognizer) with different parameters through YAML configuration
Example usage:
Issue reference
Fixes #XX
Checklist