Fix QTIP port selection

[guhetier]

Description

Fixes #5346.

When creating a QTIP listener with a wildcard port:

• a UDP socket is created first (to reserve the UDP port as XDP will take it over), and the OS would assign an ephemeral port to it
• a TCP socket is created second (to reserve the TCP port as XDP will take it over)
  • but instead of re-using the same port, the initial config was re-used, and the OS would assign a different ephemeral port
  • this second port would override the first one in the MsQuic socket config

The main consequences of this bug are:

• the right UDP port was not reserved when creating a listener with a wildcard port
• if later on, the OS assigned the UDP port matching the listener TCP port, MsQuic would fail to create a binding (causing the test failure we observed)

Creating a listener without a port set is largely a test scenario.
Creating a client connection with an unspecified a port was ok because only a TCP or a UDP socket is created for client connection.

Testing

C/I. We should add some test to validate port reservation in XDP scenarios, but it will take efforts to enable test to create sockets cross-platform.

Documentation

N/A

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.65%. Comparing base (e71ea64) to head (7911fd3).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5626      +/-   ##
==========================================
- Coverage   84.88%   84.65%   -0.23%     
==========================================
  Files          60       60              
  Lines       18663    18663              
==========================================
- Hits        15842    15800      -42     
- Misses       2821     2863      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ProjectsByJackHe]

Thanks a lot for this!

The old code was at best redundant and at worst causing these spurious bugs.