-
Notifications
You must be signed in to change notification settings - Fork 618
Update Connection reference counting to use ref counting APIs #5584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anrossi
wants to merge
8
commits into
main
Choose a base branch
from
anrossi/connection-ref-count-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
reviewed
Nov 13, 2025
guhetier
reviewed
Nov 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5584 +/- ##
==========================================
- Coverage 85.62% 84.86% -0.76%
==========================================
Files 60 60
Lines 18663 18663
==========================================
- Hits 15980 15839 -141
- Misses 2683 2824 +141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
reviewed
Nov 14, 2025
mtfriesen
reviewed
Nov 17, 2025
c33dff3 to
be2fc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
QUIC_CONNECTIONRefCount to useCXPLAT_REF_COUNTand also update the detailed ref counts to use theCXPLAT_REF_COUNTtype. Related to #5570Testing
CI
Documentation
N/A