Fix ANSI escape filtering to handle OSC 3008 audit logs from systemd 258 #4124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora 43 (systemd 258) introduces OSC (Operating System Command) 3008 ANSI escape sequences for sudo audit logging when PTY is allocated. These sequences appear in command output and break regex parsing in tools like lspci. OSC sequences have format: ESC ] <data> BEL or ESC ] <data> ESC Example: \x1b]3008;start=UUID;user=name;hostname=host;...\x1b The previous regex pattern had a character class bug: the range \-_ (0x5c-0x5f) inadvertently included ] (0x5d), causing the regex to match ESC and ] as separate characters instead of recognizing the full OSC sequence. Changes: - Reordered alternation to match OSC pattern first, preventing premature matching by the single-character escape range detecting ESC \ terminator - Supports both BEL (0x07) and ST (ESC \, 0x1b 0x5c) terminators Tested with: - OSC 3008 sequences from Fedora 43 systemd 258 - CSI sequences (existing functionality) - Single-character escapes (existing functionality) - Both BEL and ST terminators This fix maintains backward compatibility with existing ANSI escape filtering while handling modern systemd audit logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 43 (systemd 258) introduces OSC (Operating System Command) 3008
ANSI escape sequences for sudo audit logging when PTY is allocated.
These sequences appear in command output and break regex parsing in tools
like lspci.
OSC sequences have format: ESC ] BEL or ESC ] ESC Example: \x1b]3008;start=UUID;user=name;hostname=host;...\x1b
The previous regex pattern had a character class bug: the range -_
(0x5c-0x5f) inadvertently included ] (0x5d), causing the regex to match
ESC and ] as separate characters instead of recognizing the full OSC
sequence.
Changes:
matching by the single-character escape range
detecting ESC \ terminator
Tested with:
This fix maintains backward compatibility with existing ANSI escape
filtering while handling modern systemd audit logging.