Fix Maven task rebuild when using jacoco for code coverage #21472

v-gayatrij · 2025-11-20T10:16:56Z

Context

Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 Associated WI: AB#2327840

Task Name

MavenV4

Description

Remove second maven run(during code coverage publishing step) to avoid running maven lifecycle phases twice.
The second adds verify phase when JaCoCo is selected as the code coverage -

azure-pipelines-tasks/Tasks/MavenV4/maventask.ts

Line 460 in 54f548f

mvnReport.arg("verify");

This is because JaCoCo plugin binds its check goal to the Maven verify phase, which ensures that all tests have run and their coverage data is available - #6458 (comment).

This PR combines below 2 maven runs adding verify phase to the first run:

run to execute maven goals:

azure-pipelines-tasks/Tasks/MavenV4/maventask.ts

Line 268 in 54f548f

return mvnRun.exec(util.getExecOptions());

maven run before publishing code coverage:

azure-pipelines-tasks/Tasks/MavenV4/maventask.ts

Line 462 in 54f548f

mvnReport.exec().then(function (code) {

Risk Assessment (Low / Medium / High)

Low. Changes covered under feature flag

Change Behind Feature Flag (Yes / No)

Yes

Tech Design / Approach

Design has been written and reviewed.
Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

User guides, API specs, system diagrams, or runbooks are updated.

Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect these changes.

Additional Testing Performed

canary test pipeline runs:

FF enabled - Pipelines - Run 20251125.8
FF disabled - Pipelines - Run 20251125.7

Logging Added/Updated (Yes/No)

Appropriate log statements are added with meaningful messages.
Logging does not expose sensitive data.
Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
Events are tagged with proper metadata for filtering and analysis.
Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

All impacted internal modules, APIs, services, and third-party libraries are analyzed.
Results are reviewed and confirmed to not break existing functionality.

Checklist

Related issue linked (if applicable)
Task version was bumped — see versioning guide
Verified the task behaves as expected

v-gayatrij · 2025-11-20T10:25:35Z

/azp run

azure-pipelines · 2025-11-20T10:25:58Z

Azure Pipelines successfully started running 3 pipeline(s).

v-gayatrij · 2025-11-25T03:38:47Z

/azp run

azure-pipelines · 2025-11-25T03:39:06Z

Azure Pipelines successfully started running 3 pipeline(s).

v-gayatrij · 2025-11-25T06:54:16Z

Tasks/MavenV4/maventask.ts

+                const verifyOrLaterPhases = ['verify', 'install', 'deploy'];
+                const hasVerifyOrLater = mavenGoals.some(goal => verifyOrLaterPhases.includes(goal.toLowerCase()));
+
+                if (!hasVerifyOrLater) {


Check if the user input in goals property has verify or a later phase as this will eventually execute verify phase.
If not, append verify argument to mvn command.

As per https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#default-lifecycle, install and deploy phases come after verify phase.
Since maven executes all the phases in sequential order upto the specified phase, adding verify to maven run command will not be needed if a later phase is already given as input.

v-gayatrij · 2025-11-25T07:10:37Z

Tasks/MavenV4/maventask.ts

            }
-            mvnRun.arg(mavenGoals);
+
+            if (tl.getPipelineFeature('RemoveDuplicateMavenRun') && isCodeCoverageOpted && ccTool.toLowerCase() === "jacoco") {


Running maven upto verify phase is needed only when jacoco is selected as code coverage - tool.

azure-pipelines-tasks/Tasks/MavenV4/maventask.ts

Line 460 in 391cb3d

mvnReport.arg("verify");

If jacoco is not selected as code coverage tool, flow will be as earlier and adding verify will not be required.

v-gayatrij · 2025-11-25T08:45:25Z

/azp run

azure-pipelines · 2025-11-25T08:45:45Z

Azure Pipelines successfully started running 3 pipeline(s).

v-gayatrij · 2025-11-25T09:09:20Z

Tasks/MavenV4/maventask.ts

-                sendCodeCoverageEmptyMsg();
-                defer.reject(err);
-            });
+        if (tl.getPipelineFeature('RemoveDuplicateMavenRun')) {


Remove maven execution if FF is enabled. The flow for both jacoco and cobertura code coverage tools will remain same in this case.

v-gayatrij · 2025-11-25T10:12:06Z

Tasks/MavenV4/Tests/L0.ts

        assert(testRunner.ran('/home/bin/maven/bin/mvn -f pom.xml help:effective-pom'), 'it should have generated effective pom');
-        assert(testRunner.ran('/home/bin/maven/bin/mvn -f pom.xml clean package'), 'it should have run mvn -f pom.xml package');
+        if (tl.getPipelineFeature('RemoveDuplicateMavenRun')){
+            assert(testRunner.ran('/home/bin/maven/bin/mvn -f pom.xml clean verify'), 'it should have run mvn -f pom.xml verify');


Goals property has package as input in the task setup. The code coverage tool selected is JaCoCo.

azure-pipelines-tasks/Tasks/MavenV4/Tests/L0RestoreOriginalPomXml.ts

Line 21 in 391cb3d

goals: 'package',

In this case, verify will be appended to maven command as it executes after package phase as per Maven's build lifecycle - https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#default-lifecycle.

tarunramsinghani · 2025-11-26T04:54:58Z

Tasks/MavenV4/Tests/L0.ts

+        if (tl.getPipelineFeature('RemoveDuplicateMavenRun')){
+            assert(testRunner.ran('/home/bin/maven/bin/mvn -f pom.xml clean verify'), 'it should have run mvn -f pom.xml verify');
+        }


How is this tested ? what is the mechanism to enable flag for L0 as this does not run in pieline the tl.getPipelineFeature('RemoveDuplicateMavenRun') will always be false ?

I think we need 1 test with FF disabled and 1 with enabled.

v-gayatrij and others added 3 commits November 18, 2025 15:32

remove duplicate maven run for verify phase

c5f222b

add FF

590ac15

Merge branch 'master' into users/v-gayjaiswal/maven-run-fix

9088115

update condition

a8de5d3

v-gayatrij commented Nov 25, 2025

View reviewed changes

fix condition

5a1e776

v-gayatrij commented Nov 25, 2025

View reviewed changes

v-gayatrij marked this pull request as ready for review November 25, 2025 09:12

v-gayatrij requested review from a team and tarunramsinghani as code owners November 25, 2025 09:12

v-gayatrij commented Nov 25, 2025

View reviewed changes

tarunramsinghani reviewed Nov 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Maven task rebuild when using jacoco for code coverage #21472

Fix Maven task rebuild when using jacoco for code coverage #21472

v-gayatrij commented Nov 20, 2025 •

edited

Loading

Uh oh!

v-gayatrij commented Nov 20, 2025

Uh oh!

azure-pipelines bot commented Nov 20, 2025

Uh oh!

v-gayatrij commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

v-gayatrij Nov 25, 2025

Uh oh!

v-gayatrij Nov 25, 2025 •

edited

Loading

Uh oh!

v-gayatrij commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

v-gayatrij Nov 25, 2025

Uh oh!

v-gayatrij Nov 25, 2025

Uh oh!

tarunramsinghani Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix Maven task rebuild when using jacoco for code coverage #21472

Are you sure you want to change the base?

Fix Maven task rebuild when using jacoco for code coverage #21472

Conversation

v-gayatrij commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Task Name

Description

Risk Assessment (Low / Medium / High)

Change Behind Feature Flag (Yes / No)

Tech Design / Approach

Documentation Changes Required (Yes/No)

Unit Tests Added or Updated (Yes / No)

Additional Testing Performed

Logging Added/Updated (Yes/No)

Telemetry Added/Updated (Yes/No)

Rollback Scenario and Process (Yes/No)

Dependency Impact Assessed and Regression Tested (Yes/No)

Checklist

Uh oh!

v-gayatrij commented Nov 20, 2025

Uh oh!

azure-pipelines bot commented Nov 20, 2025

Uh oh!

v-gayatrij commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

v-gayatrij Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

v-gayatrij Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-gayatrij commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

v-gayatrij Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

v-gayatrij Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

tarunramsinghani Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

v-gayatrij commented Nov 20, 2025 •

edited

Loading

v-gayatrij Nov 25, 2025 •

edited

Loading