-
Notifications
You must be signed in to change notification settings - Fork 7.5k
CmdPal: Add settings cards to adaptive cards [Experiment] #43610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CmdPal: Add settings cards to adaptive cards [Experiment] #43610
Conversation
|
@niels9001 Hi! I heard you want the checkbox in settings to look like |
...es/cmdpal/Microsoft.CmdPal.UI/Controls/AdaptiveCards/AdaptiveSettingsComboBoxInputElement.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
|
Oooh I LOVE this 🤩! Would nesting be possible too? Like, rendering some of these as partnof an Expander? Total stretch goal though.. this is awesome! |
This comment has been minimized.
This comment has been minimized.
|
oh hell yes |
|
Honestly I had thought we would need to do something like creat our own |
|
@zadjii-msft @michaeljolley One minor but significant issue is that this still resides in the SDK, so any change requires the extension to be recompiled before it takes effect. What if the settings were more declarative, with the host handling the transformation? This would limit customization to predefined controls, but could be balanced by providing a host-adapter container (SettingsCard) that’s injected with a user-defined adaptive card element. It comes with trade-offs—it might offer better consistency and shield extension authors from changes, but it also adds complexity. Just food for thought 🍗 |
Summary of the Pull Request
Caution
WIP
Should we adapt to adaptive cards, or adapt adaptive cards to fit our needs?
Pictures? Pictures! ... WIP
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed